Skip to content

ARROW-5284: [Rust] Replace libc with std::alloc for memory allocation #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunchao wants to merge 6 commits into from
Closed

ARROW-5284: [Rust] Replace libc with std::alloc for memory allocation #4273

sunchao wants to merge 6 commits into from

Conversation

@sunchao
Copy link
Member

@sunchao sunchao commented May 8, 2019

No description provided.

andygrove
andygrove approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

rust/arrow/src/memory.rs Outdated
// under the License.

//! Defines memory-related functions, currently mostly to make this library play nicely
//! with C.
Copy link
Member

@andygrove andygrove May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment still relevant?

Copy link
Member Author

@sunchao sunchao May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem related anymore. Will delete later.

@sunchao
Copy link
Member Author

sunchao commented May 10, 2019

Please do not commit this yet - I still need to investigate the windows test failure.

@nevi-me
Copy link
Contributor

nevi-me commented May 11, 2019

Hey @sunchao, I'm able to reproduce the failure, it comes from buffer::tests::test_from_raw_parts. specifically: Buffer::from_raw_parts(null_mut(), 0); causes the failure.

I ran cargo test with 1 thread to find the offender.

@sunchao
Copy link
Member Author

sunchao commented May 14, 2019

Thanks @nevi-me . I think it fails because it was trying to dealloc a null pointer. Not sure why it doesn't fail on linux.

nevi-me
nevi-me approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would this fix the 64-byte counting issue that I was experiencing on #4167 ?

@sunchao
Copy link
Member Author

sunchao commented May 14, 2019

LGTM! Would this fix the 64-byte counting issue that I was experiencing on #4167 ?

No. I'm going to work on that next.

@sunchao sunchao closed this in 608e846 May 14, 2019
@sunchao sunchao deleted the ARROW-5284 branch May 15, 2019 00:06
@asfimport asfimport mentioned this pull request May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

@nevi-me nevi-me nevi-me approved these changes

Assignees

No one assigned

Labels

Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunchao @nevi-me @andygrove